Skip to content

London | 26-ITP-January | Damian Dunkley | Sprint 3 | Refactoring dead-code#1057

Open
DamianDL wants to merge 6 commits intoCodeYourFuture:mainfrom
DamianDL:coursework/sprint-3-dead-code
Open

London | 26-ITP-January | Damian Dunkley | Sprint 3 | Refactoring dead-code#1057
DamianDL wants to merge 6 commits intoCodeYourFuture:mainfrom
DamianDL:coursework/sprint-3-dead-code

Conversation

@DamianDL
Copy link

@DamianDL DamianDL commented Feb 25, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Changes to exercises 1&2- please review

@github-actions

This comment has been minimized.

Sign in to view
5 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@DamianDL DamianDL added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Feb 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
@DamianDL DamianDL changed the title London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework/sprint 3 dead code London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework sprint 3 dead code Feb 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
@DamianDL DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@DamianDL DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@DamianDL DamianDL changed the title London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework sprint 3 dead code London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework-sprint-3-dead-code Feb 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@DamianDL DamianDL changed the title London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework-sprint-3-dead-code London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework/sprint3/2-practice-tdd Feb 26, 2026
@github-actions

This comment has been minimized.

Sign in to view
@DamianDL DamianDL changed the title London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework/sprint3/2-practice-tdd London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework/Sprint-3/3-dead-code Feb 26, 2026
@github-actions

This comment has been minimized.

Sign in to view
8 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@DamianDL DamianDL changed the title London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework/Sprint-3/3-dead-code London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework/sprint3/3-dead-code Feb 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@DamianDL DamianDL changed the title London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework/sprint3/3-dead-code London | 26-ITP-January | Damian Dunkley | Sprint 3 | Refactoring dead-code Feb 27, 2026
@DamianDL DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 27, 2026
hkavalikas
hkavalikas suggested changes Mar 1, 2026
View reviewed changes
Sprint-3/3-dead-code/exercise-1.js
Copy link

@hkavalikas hkavalikas Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out and removing are not the same thing; knowing that, can you tidy these files up?

Sprint-3/3-dead-code/exercise-1.js
// console.log(greetingStr);
}

testName = "Aman";
Copy link

@hkavalikas hkavalikas Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will either result in a variable in the global scope or throw an error. Can you find a way to change it?

Sprint-3/3-dead-code/exercise-2.js
Copy link

@hkavalikas hkavalikas Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same note re; comment vs deletion

@hkavalikas hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hkavalikas hkavalikas hkavalikas requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Structuring-And-Testing-Data The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DamianDL @hkavalikas